Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved sanity check for mapping file vs. data in AddData.py #150

Open
ohsOllila opened this issue Sep 15, 2023 · 0 comments
Open

Improved sanity check for mapping file vs. data in AddData.py #150

ohsOllila opened this issue Sep 15, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ohsOllila
Copy link
Member

Currently AddData.py checks that mapping file and simulation have the same amount of atoms. If not, they script is stopped but an option to bypass is given. This is good, but it does not give any further information where the problem might be. In practice, I have been ending up to bypass the problem and then running analysis codes to get better idea where the problem is, and then returning back to AddData after locating and fixing the problem. This is not ideal.

I think that the solution would be to write a better sanity check function to AddData.py that would not only check the number of atoms, but also if the names match and report which atoms cause the problem.

@NMRLipids NMRLipids deleted a comment from JHoeflich1 Apr 3, 2024
@comcon1 comcon1 added the enhancement New feature or request label Jan 12, 2025
@comcon1 comcon1 added this to the Release for software paper milestone Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants