-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isomers of PG lipids #38
Comments
I once uploaded simple tcl script to test this. I can rework it with python if needed. |
Hi @pbuslaev, in your tcl script you use the vmd function |
Hi @patrickfuchs, no currently I don't have it in python. But that should be easy to implement. I am currently modifying the script for dihedral angle calcularion to make it work with MDAnalysis and I can add an option for imporpers there. However, if the isomers need to be checked asap, tcl script is a there and could be used. |
Just to make it clear, when I said "without too much work", I meant it's just adding one line of code to the function above to get the angle. Thus, if you want, I can send you this function which you can incorporate into your script that goes over a trajectory. Let me know. |
Sure, that would be great if you send me the function. |
@ohsOllila Could you please share the list of POPG trajectories needed to be analyzed? |
Technically I do not have such a list because all these trajectories are already indexed in the new databank format. I have added a template python code which goes through trajectories containing POPG that are in the databank: This script goes through all the data in the databank. If there is POPG in the simulation, it downloads the trajectory, makes lipids whole, searches the mapping file etc. Then you are ready to call your analysis function or write them within the code (this where the comment in lines 129-140 locates). This is how the analysis from the NMRlipids databank is supposed to work. Let me know if you have any questions. If you have your function, I can also try put it inside this code. |
Hi @ohsOllila, If I understand it right, to test the enantiomers of POPG, it is enough to calculate the Here is the script that iterates over all trajectories with POPG and calculates this improper. I tested it for one trajectory and there is only one peak observed. Unfortunately I can't run the whole analysis on my machine currently. So if you find the script useful, please use it. |
Hi @ohsOllila, @pbuslaev, I think I have a function that is able to infer the R-S configuration of an asymetric carbon. It took more time because it was slightly more difficult than expected. In fact, I don't use the classical improper definition like what we use for force fields. Instead I use the angle (that I call theta) between the vector bissecting the 3 atoms asymetric carbon / two heaviest atoms. Let me explain using a figure (I generated this from a CHARMM trajectory, this snapshot corresponds to the 1st POPG from the tpr file of the system, the asymetric carbon is called The numbers in green indicate the 4 substituents by descending mass. Three vectors have to be determined :
In the end, I calculate the angle theta between Do you agree with my reasonning ? The python function takes as argument the central carbon and the 4 substituents by descending mass as numpy arrays. The atom order is important. @pbuslaev since you already implemented something, do you still need my function? It'll be useful anyway for buildH to tell which H is pro-R or pro-S. Last question, do we really need to make this check over whole trajectories? In principle, the absolute config should not change during an all-atom trajectory. And for a united-atom traj, there should be an improper preventing the switch. |
Hi @patrickfuchs, I agree that the method you use for defining R- and S- conformation works. But I also think that calculation of impropers works as well. I also agree that we don't need to analyze the whole trajectories. As for buildH, I agree that it might be useful to know in which conformation H is. If needed, I can probably work on that later as well. |
All right. I agree your version that uses impropers also works.
OK thanks. I'll make you know if we need help. |
Thanks @pbuslaev and @patrickfuchs, I agree with you. I think that for NMRlipids IVb the dihedral calculation is sufficient, but how we will handle the isomers in the databank is yet to be discussed. Approach by @patrickfuchs may be useful there. I slightly modified to code by @pbuslaev to read only gro file and added flexibility to residue names, and ran the analysis over PG structures in the databank. They are all the R conformation which is the biologically abundant one (I would appreciate if someone would double check this from the data). The updated code is here https://github.com/NMRLipids/NMRlipidsIVPEandPG/blob/master/scripts/calcISOMERS.py and the dihedral results in files NMRlipidsIVPEandPG/Data/dihedral/////isomer_POPG_M_G3C4_M_M_G3C5_M_M_G3C5O1_M_M_G3C6_M.dat. I have now udated the explicit molecule names in the method section in the manuscript, and added a paragraph in the SI: I think that we are done with this issue for NMRlipids IVb, but we have to come back to this in discussions about the databank. |
@ohsOllila, is there already an open issue on the databank project to start the discussion, or maybe somewhere on the blog? We started to think about it in the buildH project (patrickfuchs/buildH#63), and realize that implementing a pro-R / pro-S assignement in a consistent way would probably require to change the def files. Also, we thought that it would be nice to have consistent .def files between NMRlipids projects and buildH. |
We do not have an own repository for the databank project yet. I have opened a issue about having enantiometric information in the databank into this repository: #41. Idea is that we would not use the def files anymore in the databank. All the information should be read from the mapping files. We can continue the discussion in the new issue, but I think that we also need a online meeting about the databank soon. |
Thanks @ohsOllila, so I continue the discussion there. |
I think that this issue is solved for NMRlipids IV. For the databank, I have opened a issue in the databank repository NMRLipids/Databank#1. Therefore, I close this issue. |
* Update results with corrected dihedral for Lipid17 POPG from NMRLipids#12 * Add data from MacRog POPE * Update ECC-lipid results * Update ECC-lipid data * Update links to the data * Update analysis script * Reads molecule numbers and temperature from tpr. Saves the dictionary in json * Simulations * Fixed README.json * modified OrderParameter.py and plotDATA.ipynb to calculate angles of PN vectors * average of angle added * Add readDATA.ipynb demo and clean repo * Add DataBank presentation * Vector calculation is still in plotDATA.ipynb. Calculates errors * Lipid numbers per leaflet * AddData: Order parameters for systems with a mixture of lipids, plotDATA: plots of PN vector angles, order parameters and dihedrals * Minor fix in plotDATA * Updates in plotDATA * minor changes * Fixed file paths in dihedral angles cell * removed hard coded atom names for POPG * Update default location of mapping file in the AddData.ipynb * Update plain python verison of AddData * Update plain python verison of AddData * Update AddData.py to version that read the user_information from file * Choose all heavy atoms for dihedral calculation * Updates in P-N vector calculation and data storage in plotDATA.ipyn * Add P-N vector plot * Update P-N vector angle and order parameters results to the manuscript * Update dihedral analysis * Update dihedral calculation * AddData.py can be looped over many simulations given .py file containing information to be put in dictionary * most recent version of OrderParameter.py * Add calculation of dihedral angle of POPC, POPE, POPG and POPS * Fix phopshorus oxygens in mappingPOPScharmm.txt * Update dihedral results * Update dihedral results * Move databank buiding to a own folder and make randomly named folder for temporary files to fix the issue NMRLipids#26 * Update POPC charmm results * Add temporary dihedral analysis script * Update dihedral calculatio script * Update dihedral plot * Add results with ions and preliminary plotting script * Add data * Update dihedral and ion binding results in the manuscript * Update dihedral results * Update PN vector angles * Update PNangle-eps-converted-to.pdf * Update PNangle-eps-converted-to.pdf * Add P-N vector calculations and related data * Add data with cholestrol to databank * Add data with cholestrol to databank * Add PN vector angles from cholesterol simulations * Add calcPNvectors.py * Add data with cationic surfactant * Add analysis of dihedral angles from pdb * Add PC dihedral results from PDB * AddData.ipynb and .py work with Amber/ECClipid simulations * Add PE names * update readDATA example * Add PE results from PE and figures to manu * some small errors fixed * Update AddData.py * fixed AddData.py, OrderParameter.py * Fix for proper ouput of lipids with zero quantity * Update data adding to databank, lipid17 entries do not work yet. * Update data in databank format * Update scripts * Clean scripts * Update manuscript and data * AddData.py works for lipid17 * Update PNangle results * Update manuscript * Update manuscript * Update manuscript * Update manuscript * Update dihedral results into the manuscript * Update manuscript * United atom simulation handling added * Added opnmm dictionary and os instead of ipython as suggested in pull request by batukav * Update manuscript * AddData instructions * Update manuscript * Update manuscript * Update manuscript * Update pdfs * fixed POPCPOPG73gromos_ckp310K.py * Add P-N vector angle results * file paths to def file fixed * file paths to def file fixed * Add P-N vector results * fuxed def file paths * Add PNangleRESULTS * Add P-N orientation data * Update data * Update manuscript * Update SI * Update SI * Update manuscript * Update intro * Update manuscript * updated user instructions * Add APL results * molecule_ff_dict dictionary added for specifying force fields for different molecules * Update manuscript * AddData.py prints error and quits running if downloads fail * updated user instructions * Update manuscript * Update authors * Update authors * Remove manuscript (preparing for submodule) * Manuscrip as submodule * Add figure * Add figures * Add figures * Add figures * Update mansucriopt * Update pdfs * Add density profiles * Add density profile * Update density profiles * Update dihedral figure * Update dihedral figures, move ion binding to SI, and update discussion * Update pdf * Update figure 2 * Update order parameter plotting * Add calcISOMERS.py template * Add calcISOMERS.py template for isomer calculations in issue NMRLipids#38 (comment) * Add PG headgroup isomer data * Update pdfs * FIx typo * Update analysis of dihedrals from PDB as discussed in issue NMRLipids#40 * Update pdfs * Add 0-360 dihedral data * Add dihedral figures in kT units * Update results for POPC:POPG 4:1 Lipid17ecc results * Update corrected version of this dataset https://doi.org/10.5281/zenodo.3997183 * Update correct Lipid17ecc POPC:POPG 4:1 mixture data * Update data * Add comments to calcPNvectors.py * Update comment in plotOPsWITHsalt.ipynb * Add APL results * Add APL calculation script * Update energies to figure 2 * Update energies to figure 2 * Update text related to the relative energies * Remove old scripts * Update manuscript * Update manuscript * Plotting new distributions from PDB * Update dihedral results from PDB * Partly updated SI fig on PE OPs. * Add new dihedral distribution from PDB plot based on discussion in issue NMRLipids#40 * Update DIHdistFROMpdb.ipynb * Update PDB plot as discussed in issue NMRLipids#40 * Update text * Update text * Add author * Add author * Update methods for the analysis from PDB as discussed in issue NMRLipids#40 * Update text * Update text * Update to correct POPE lipid17 data as discussed in issue NMRLipids#12 * Updates on PE OP plot. * Updates for figure 1 * Update details in SI * Update simulation details * Comment out data that is not used * Updated pure PE figure * Add POPS order parameters datafile * Updates for figure 1 * Update text * Update pdfs * Updated pure PE order parameter plot. * Update pdfs * Updates in SI * Updated pure PE order parameter plot. * Fine-tuned the sweet spots for pure PE oreder parameter plot. * Update manu * Update manu pdf * Added scripts for PDB analysis and Dihedral calculations with MDAnalysis * Update pdfs * Add author * Remore space from PDBanalysis.ipynb name * Update panel D in figure 1 * Update printing the list of pdb codes * Add table listing PDBids used in the analysis of protein-bound lipids * Update pdfs * Update pdfs * Update simulation details * Update pdf * Removed overlaps from PG OP plot. * Tuning of PG OP plot. * Switched to using the average of the 2H for DPPG alpha OP, because these were measured from S enantiomer. And because average of the S OPs is known to match the non-forking R OP (Wohlgemuth1980). * Update PG figure in SI * Update pdfs * Update fig 3 * Update pdfs * Add submitted version * Update text * Update manuscript and cover letter Co-authored-by: ohsOllila <[email protected]> Co-authored-by: Kiirikki Anne M <[email protected]> Co-authored-by: akiirik <[email protected]> Co-authored-by: Ollila Samuli O H <[email protected]> Co-authored-by: Test <[email protected]> Co-authored-by: Ollila Samuli O H <[email protected]> Co-authored-by: Markus Miettinen <[email protected]> Co-authored-by: ivan-gushchin-mipt <[email protected]> Co-authored-by: pbuslaev <[email protected]>
PG from avanti is racemic. We should check the isomers in simulations.
@patrickfuchs mentioned in the meeting that he may have a code or function for checking available. That would help the analysis when combined with the databank.
The text was updated successfully, but these errors were encountered: