Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many issues #187

Closed
nhartland opened this issue May 3, 2018 · 8 comments
Closed

Too many issues #187

nhartland opened this issue May 3, 2018 · 8 comments
Assignees

Comments

@nhartland
Copy link
Member

We have a lot of duplicate issues or issues about things that may have been solved.
We could do with going through them.

For example, I'm pretty sure
#34 = #44
#178 = #176 = #14
#26 = #21 = #186

Just from a quick glance, there are probably more

@nhartland
Copy link
Member Author

#38 = #25

#77 = #22

@scarrazza
Copy link
Member

I agree, thanks for collecting this.

@nhartland
Copy link
Member Author

I think #37 and #24 may have been solved already

@Zaharid
Copy link
Contributor

Zaharid commented May 3, 2018

Thanks.

Ok for the rest. Reading the covmat business.

@nhartland
Copy link
Member Author

I had guessed #24 had been solved by that LHAPDF config bug. Is it a separate issue then?

@Zaharid
Copy link
Contributor

Zaharid commented May 4, 2018

That's a bug in the nnpdf side. The code example still segfaults on master.

@Zaharid
Copy link
Contributor

Zaharid commented May 4, 2018

In fact it even says what the problem is

Yes, sine we don't define it, it's copying fLHA by pointer, and then freeing it two times.

@nhartland
Copy link
Member Author

There is a bit of overlap between #29 and #95, in that coverage reports are also mentioned in #95.
Other than that I don't see much else to be removed. Which is a bit distressing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants