Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding style for MELODIES-MONET #300

Open
blychs opened this issue Oct 28, 2024 · 1 comment
Open

Coding style for MELODIES-MONET #300

blychs opened this issue Oct 28, 2024 · 1 comment

Comments

@blychs
Copy link
Collaborator

blychs commented Oct 28, 2024

Hi all,
I suggest taking some of the coding style from MONETIO.
I think that just merging a run of Black and isort to format the code without modifying it would help. There is already a pyproject.toml file with the relevant configurations, but it hasn't been used. It will be a BIG PR though, since those coding guides have not been followed until now.
It won't change the contents of the code, just the formatting, but it will require all of us working in branches to follow it. I believe that it will make it easier to maintain, and it would be consistent with MONETIO, and it will be helpful for the future if we get developers. I think that if we start getting more devs, it will really help. In the not to distant future, we should aim for full pre-commits as MONETIO has.
Let me know your thoughts, @zmoon, @rschwant .
Cheers
Pablo

@rschwant
Copy link
Collaborator

rschwant commented Nov 4, 2024

Plan is to spend the next 3 months getting coding done for version 1 that people have already started. Then we will have a brief pause on coding development when we pull this in before version 1 occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants