Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ground and model with same name (csv). #307

Open
blychs opened this issue Nov 1, 2024 · 1 comment
Open

Ground and model with same name (csv). #307

blychs opened this issue Nov 1, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@blychs
Copy link
Collaborator

blychs commented Nov 1, 2024

Hi all,
There is a bug in surfplots if ground stations and model have the same variable named. The bug is caused because monet changes the name by adding "new", whereas the pairing tool in melodies-monet tool.py utility (mobile_and_ground_pair) uses directly pandas merge_asof, which in that case changes the name by adding _x, _y, etc.
Then, the plotting tool looks for the variable "_new", which does not exist.
Probably the easiest fix is adding _new to repeated variables, and sticking to the MONET method, although I tend to think that the pandas way of dealing with it is probably better.
What do you think, @zmoon ?
Cheers
Pablo

@blychs blychs added the bug Something isn't working label Nov 1, 2024
@zmoon
Copy link
Collaborator

zmoon commented Nov 1, 2024

@blychs this could likely be done in your pandas merge with suffixes=(None, '_new') (which is how monet combinetool does it too). Depending on context of course, I do like the approach of only adding a suffix to the "new" column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants