Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAs introduced in herring pull #39

Open
slucey opened this issue Jan 14, 2023 · 3 comments
Open

NAs introduced in herring pull #39

slucey opened this issue Jan 14, 2023 · 3 comments
Assignees

Comments

@slucey
Copy link
Member

slucey commented Jan 14, 2023

Investigate what is causing the warning:

Warning message:
In lapply(.SD, as.numeric) : NAs introduced by coercion

Seems to enter from get_herring_data function.

@sgaichas sgaichas self-assigned this Aug 29, 2024
@sgaichas
Copy link
Member

Herring come in with the get_comlandr_raw function and are replaced in the get_herring_data function but this results in fewer rows, need to compare the two outputs with herring catch data in assessment.

@sgaichas
Copy link
Member

sgaichas commented Aug 29, 2024

Datasets pulled using get_comland_raw and get_herring_data using code in herringtest.Rmd, stored on work3/EDAB/VAST_indices/testcomlandr:

  • comland_raw.rds is the full raw comland pull
  • comland_raw_herring.rds is the subset: comland_raw[NESPP3 == 168, ]
  • herring.rds is the output of get_herring_data up to the point where it would replace the subset above

some interim datasets are saved:

  • herring_catch.rds is the raw pull from NEFSC_GARFO.maine_herring_catch
  • herring_price.rds is the price calculated from comland_raw_herring
  • herring_util.rds is the utilization code pulled from comland_raw_herring (need to verify)

Next steps, I'll go through these to see where they differ

@sgaichas
Copy link
Member

sgaichas commented Sep 3, 2024

added some initial comparisons and questions in the discussion board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants