Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with unknowns #40

Open
slucey opened this issue Jan 14, 2023 · 3 comments
Open

Problems with unknowns #40

slucey opened this issue Jan 14, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@slucey
Copy link
Member

slucey commented Jan 14, 2023

Unknown areas are not allocating the way they have in the past. This was first noticed during the SOE leads meeting when looking at the Bennet Index.

@slucey
Copy link
Member Author

slucey commented Jan 14, 2023

First issue was that revenue was not proportioned correctly. Unknown matches would proportion the landings but not the revenue. So an unknown matched to three known records would triple the revenue from that catch.

This issue has been resolved.

@slucey
Copy link
Member Author

slucey commented Jan 14, 2023

Second big issue is that unknown records would match with unknown variables. So say a record had three known variables and one unknown variable, it could match with known records with the same missing variable. This allows for easier matches that may not be correct. This was noticed with Eastern Oyster (NESPP3 789) showing up in the Gulf of Maine as more important than lobsters.

@slucey
Copy link
Member Author

slucey commented Jan 14, 2023

Coding it so it matches by complete cases before winnowing down variables. Still need to add a combination function to get different combinations of known variables. gtools::combinations is a promising tool to get this to work.

@slucey slucey self-assigned this Jan 14, 2023
@slucey slucey added the bug Something isn't working label Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant