Test data pull from stockeff

[andybeet]

stockeff.mv_cf_landings table now have species value included and pull from CAMS from 2020+. Prior to this AA tables are used.

We should pull data from this table and compare to current comlandr implementation.

We should also monitor the CAMS portion of the data through time to see how frequently they are updated, since they are now live tables.

[andybeet]

Looks like SPPVALUE is pretty consistent post 1981 (post WOLAND era)
This plot show the areas in which landings have the most value

[andybeet]

WOLAND data not added by StockeEff folks
"We did not include WOLAN because there were concerns as to the validity of the data. We have no way of validating it and had heard a few years ago that this field was not populated properly in this series of objects. Since Population Dynamics does not use this field we did not continue paying attention to it (did somebody validate it/were there updates)."

[sgaichas]

Are Atlantic herring landings already integrated in stockEff?

When I use get_comland_raw_data from the stockEFF tables, I get 20481 rows with NESPP3==168 (Atlantic herring) (1964-2023)

Then in get_herring_data, when it goes to the GARFO table to get herring landings and removes those that were included in the first function, I get 13264 rows with NESPP3==168 (Atlantic herring). Fewer.

I have not yet checked the data so this may be ok, just noting here before I forget

Sorry if its a red herring haha

[andybeet]

So when we were pulling from the AA tables, herring was being replaced by herring that is pulled from its own table (maine_herring_catch table). But to answer your question as to whether STOCKEFF handles this already, i don't know. I will reach out.

[andybeet]

STOCKEFF are not hadling this, they do not replace herring with state of maine data. so we ned to look into the code for a potential bug and make sure we are pulling from the correct tables, since i believe ITD moved them/ renamed them