comlandr discards

[andybeet]

Refine discard estimates for use in SOE indicators and RPath models
Review methods

Meet on 29th August to make a decisin by 9th Sep

[andybeet]

get_comdisc_data is the main function for pulling discards. The arguments passed (comlandr data pull, names of fields, and boolean aggregation fields) are all somewhat dependent on each other. This is causing errors when there is a contradiction. For example.

If a comlandr data pull is made without aggregating the data, then the field names need to be changed.
If a comlandr pull is made with aggregateion then you must opt to aggregate the discards.

We need to add checks before running to ensure options are correct. Default arguemnts should all be geared towards the option of not aggregating the data

[sgaichas]

We can also consider a wrapper function that would pull both landings and discards because many users may want "catch" which is landings + discards. This would allow the arguments to be consistent for both.