Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check value calculations for species marketed as parts #68

Open
sgaichas opened this issue Sep 6, 2024 · 1 comment
Open

check value calculations for species marketed as parts #68

sgaichas opened this issue Sep 6, 2024 · 1 comment
Labels
review Seems fishy! Needs a review

Comments

@sgaichas
Copy link
Member

sgaichas commented Sep 6, 2024

I think we drop all parts in get_comland_raw_data:

# Remove fish parts so live weight is not double counted
if(removeParts){
comland.yr <- comland.yr[!NESPP4 %in% c('0119', '0123', '0125', '0127',
'0812', '0819', '0828', '0829',
'1731', '2351', '2690', '2699',
'3472', paste0(348:359, 8),
'3868', paste0(469:471, 4),
paste0(480:499, 8), '5018',
'5039', '5261', '5265'), ]
}

This is to ensure species live weight isn't double counted.

Potential problem that needs checking:
Species like monkfish and skates often get different prices for parts.

Ensure that our code is getting the value correct for these species for our revenue calculations and indicators.

@andybeet
Copy link
Member

Not sure i understand exactly what is getting removed and why. Also not sure i understand where the double counting is coming in. For example a pull of ALL dogfish and skate codes results in the following plots.
image
image

Now after filteing this data pull to show just the codes that would have been removed we see this:
image

So it seems like there A LOT of other codes relating to species parts that are NOT removed. Not sure why.

@andybeet andybeet added the review Seems fishy! Needs a review label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Seems fishy! Needs a review
Projects
None yet
Development

No branches or pull requests

2 participants