Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check aggregate_area and assign_unknown interaction #73

Open
andybeet opened this issue Sep 19, 2024 · 1 comment · Fixed by #78
Open

check aggregate_area and assign_unknown interaction #73

andybeet opened this issue Sep 19, 2024 · 1 comment · Fixed by #78
Assignees
Labels
bug Something isn't working

Comments

@andybeet
Copy link
Member

andybeet commented Sep 19, 2024

In aggregate_area, the landings and the value can be proportioned from a statistical area (those overlapping multiple EPUS) among EPUS.

This step is completed prior to the assign_unknown step which uses data from this previous step to "fill" in missing variables like AREA, MONTH, NEGEAR (or EPU, MONTH, FLEET) if aggArea or aggGear are turned on.

In this assign_unknow step, if a missing AREA is assigned an AREA value that overlaps two EPUs, are the value and the landings proportioned or is the original landings and value retained? If the latter then we'd be inflating landings and value

@andybeet andybeet added the bug Something isn't working label Sep 19, 2024
@andybeet andybeet linked a pull request Oct 1, 2024 that will close this issue
@andybeet andybeet removed a link to a pull request Oct 1, 2024
@andybeet
Copy link
Member Author

andybeet commented Oct 1, 2024

Unsure, but this might be irrelevant. Here's why:

Because the assign_unknowns is the last step in the process we have already aggregated areas and gears. So we are filling in missing values at the aggreate level, based on aggregated data. We should be doing the "data filling" step BEFORE the aggregation step

@andybeet andybeet linked a pull request Oct 1, 2024 that will close this issue
@andybeet andybeet self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant