Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global_det: Threshold values in ush/global_det/plot_util.py #535

Open
malloryprow opened this issue Aug 28, 2024 · 0 comments
Open

global_det: Threshold values in ush/global_det/plot_util.py #535

malloryprow opened this issue Aug 28, 2024 · 0 comments
Assignees
Milestone

Comments

@malloryprow
Copy link
Contributor

From Bugzilla 1586

The code evs_global_det_wave_grid2obs_plots_31days crashed with empty array error when ush/global_det/plot_util.py over filtered the wind data. The original threshold was set to 200, with new threshold of 500 introduced on 1.0.10 the code manages to keep the data. There is no guarantee that 500 always going to work.
The developer group is deciding on how to scientifically/logically decide on the threshold on next upgrade. This is a Bugzilla ticket to document and track progress on the problem.

For the record here is the line of code
stat_values = stat_values[stat_values<=500]

The lines in ush/global_det/plot_util.py are 1227 and 1529 that needed thought of how to handle.

Related to #534

@malloryprow malloryprow self-assigned this Aug 28, 2024
@malloryprow malloryprow added this to the EVS v2.0.0 milestone Aug 28, 2024
@malloryprow malloryprow changed the title Threshold values in ush/global_det/plot_util.py global_det: Threshold values in ush/global_det/plot_util.py Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant