-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hashes for JEDI submodules #1117
Comments
Work for this issue will be done in RussTreadon-NOAA:/feature/submodules |
Commit d480014 to |
The updated JEDI hashes bring in changes to the names of several radiance bias correction variables.
As such, the GDASApp radiance bias correction conversion script needs to be updated accordingly. Required changes are made to
The var and ens ctests assimilate amsua_n19 data with bias correction. The bias correction variable names encoded in the following bias correction files need to be updated in order for the var and ens analysis ctests to pass.
These files have been updated and are available in the following directory on Orion
@CoryMartin-NOAA : We need to update the amsua_n19 satbias files when |
In addition to updating variable names in the test data amsua_n19 bias correction files and the GDASApp bias correction conversion scripts, we also need to update bias correction variable names in the following jcb-gdas yamls
Note that similar changes need to be made to the yamls for other radiance data in Updating the JEDI submodule hashes also requires changes be made to the following jcb-gdas yamls
In both of these yamls saber block name jcb-gdas issue #6 documents the addition of the above changes to jcb-gdas branch feature/submodules. |
…pdate GDASAPP_TESTDATA path on orion (NOAA-EMC#1117)
@RussTreadon-NOAA , soca fixes are in the |
@guillaumevernieres , thank you for the soca updates. I merged
The current head of soca |
Update to soca @ 98e2be9. Build of
@guillaumevernieres - ignore this comment. My local working copy did not contain your soca fixes. Let me retest and edit this comment after tests are complete. |
Update to soca @
Look in log file for
Script
but variable We need g-w PRs #2584 and #2592 merged into g-w GDASApp Attention @guillaumevernieres , @DavidNew-NOAA , @CoryMartin-NOAA , and @danholdaway |
Ha, sorry. You need to merge develop into your branch @RussTreadon-NOAA . I commented out the post job for now, I'll turn it back on after my g-w pr is merged. |
Merge GDASApp Update working copy of DavidNew-NOAA:feature/atmensanlfv3inc to hash
Interestingly, rerunning the three failed tests after the above failure results in all three tests passing.
This behavior needs to be examined and better understood. |
Hera test
due to the reference check after each application finished. This failure is not unexpected.
|
REMINDER The names used for certain radiance bias correction terms change with updated JEDI hashes in
The updated amsua_n19 bias correction files will be copied to A change to |
Test data has been copied from |
This PR updates the hashes for select JEDI repositories in the GDASApp `sorc` directory. Updating the submodule hashes necessitates corresponding changes elsewhere in GDASApp. These additional changes include - soca updates (see GDASApp issue [#1093](#1093)) - update names for select radiance bias correction terms - correcting the path to `satbias2ioda.x` in `test/atm/test_convert_gsi_satbias.sh` Resolves #1117 --------- Co-authored-by: Guillaume Vernieres <[email protected]>
The hashes for the core JEDI component submodules in
sorc/
are several weeks old. This issue is opened to document the updating of the hashes for these JEDI components.Note: The updating of
sorc/soca
is documented in GDASApp issue #1093The text was updated successfully, but these errors were encountered: