Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use netcdf global_berror files #810

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Nov 27, 2024

Description
This PR adds the option for gsi.x to read netcdf format global_berror files.

Resolves #808
Depends on

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

ctests run on WCOSS2 (Dogwood) with Passed result for all tests.

NetCDF format global_berror files tested for various resolutions on Dogwood. Runs using netcdf and binary global_berror files yield bitwise identical analysis increment files.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing tests pass with my changes

@RussTreadon-NOAA
Copy link
Contributor Author

This PR will changed to Ready for review once

  • GSI-fix PR #25 is merged into develop
  • g-w issue #3128 is closed
  • the fix submodule hash in RussTreadon-NOAA:feature/netcdf_berror is updated
  • GSI_BINARY_SOURCE_DIR is updated to point at the new directory for staged non-ASCII GSI fix files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend GSI to read netcdf global_berror files
1 participant