gdt2gds.f causes segfault for some values of arguments

[edwardhartnett]

There are some untested conditions.

[edwardhartnett]

This code is 97.9% tested. There are three untested sections of code, all activate the same code in the w3emc library, function r63w72().

In this function we see the cryptic comment:

C> @note kgds and igds extend beyond their dimensions here
C> if pl parameters are present.

These arrays are declared to be of size 200 in the code:

  DIMENSION KPDS(200),KGDS(200),IPDS(200),IGDS(200)

But later in the code:

C EXTENSION FOR PL PARAMETERS
IF(KGDS(1).EQ.0.AND.KGDS(19).EQ.0.AND.KGDS(20).NE.255) THEN
DO J=1,KGDS(3)
IGDS(18+J)=KGDS(21+J)
ENDDO
ENDIF

The problem here is that the gdt2gds() function seems to call r63w72() in such a way as to overwrite the ends of the IGDS array, and read beyond the end of the KGDS arrray.

Is this a bug? It's not clear how this can ever work...