Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify areas for testing #27

Open
edwardhartnett opened this issue Oct 30, 2020 · 15 comments
Open

identify areas for testing #27

edwardhartnett opened this issue Oct 30, 2020 · 15 comments
Assignees

Comments

@edwardhartnett
Copy link
Contributor

We need to identify some tests that we are going to write.

I guess the best thing to start with is a WRF data file, preferably a small one. Then we can build tests around that. @GeorgeVandenberghe-NOAA can you come up with a test file?

It should be less than 50 MB in size...

@GeorgeVandenberghe-NOAA
Copy link
Contributor

@GeorgeVandenberghe-NOAA
Copy link
Contributor

@WenMeng-NOAA
Copy link

This wrf_io lib is derived by the DTC UPP team from the WRF package for reading wrf io format data e.g. hrrr, wrf in UPP . I invite
@fossell in this thread. She might provide more information.

@GeorgeVandenberghe-NOAA
Copy link
Contributor

@GeorgeVandenberghe-NOAA
Copy link
Contributor

@edwardhartnett
Copy link
Contributor Author

@GeorgeVandenberghe-NOAA we can develop the test suites as a team. ;-) You are not on your own.

So for wrf_io, the first step is to find one of the kind of WRF files we are expected to be able to read, and then we can build some tests around that. sigio and sfcio we will address in their projects, but we will start in the same place for their read code: we need a test file that we can start with. ;-)

@WenMeng-NOAA
Copy link

Our UPP regression tests include hrrr test which use hrrr model output (WRF file).

@edwardhartnett
Copy link
Contributor Author

@WenMeng-NOAA can you attach a copy of that WRF file to this issue?

@WenMeng-NOAA
Copy link

@edwardhartnett That wrf file is too large to attached in this issue. If you have Hera or WCOSS account, I will point you the location.

@edwardhartnett
Copy link
Contributor Author

Yes, please do, on hera.

@WenMeng-NOAA
Copy link

Please see /scratch1/NCEPDEV/stmp2/Wen.Meng/edward for hrrr model output on Hera.

@fossell
Copy link

fossell commented Nov 2, 2020

I'm a little late to this thread. The best course of action is what has already been initiated, using HRRR model output from EMC regression tests. While DTC does have some WRF data for testing, we are phasing out support for WRF models so this is no longer part of our work plan.

@edwardhartnett
Copy link
Contributor Author

@fossell the goal is to also have independent testing of the wrf_io library within this repo. This does not affect testing of the UPP, which is a separate effort.

The UPP uses many of the NCEPLIBS libraries. We have a refactor underway to add testing and documentation to many of them. This issue is part of that effort. The goal is to ensure that we're putting out a wrf_io library that we know works. Like all the NCEPLIBS libraries, it can and will be further tested at the UPP level, and that's great.

Well the file in question is >10 GB, so that doesn't work very well for testing. Are there any WRF files that we need to read which are smaller?

@edwardhartnett
Copy link
Contributor Author

edwardhartnett commented Nov 10, 2020

@GeorgeVandenberghe-NOAA will attempt to do this in three steps:
1 - synthesize a file using the write functions in the library, then read it.
2 - Take some use cases from UPP and make them into tests within wrf_io repo.
3 - Collect some test files (which will be large) and put them on FTP site, to be downloaded by script and used it testing.

THis will be started sometime in the next couple of weeks, we hope, after WCOSS2 problems have been sorted out.

@GeorgeVandenberghe-NOAA
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants