-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the bufr2ioda yamls #183
base: develop
Are you sure you want to change the base?
Update the bufr2ioda yamls #183
Conversation
…ome data types from int to float as expected by JEDI, some units and/or longName changes, separated aircft and aircar, separated adpsfc and sfcshp, some clean up of extra white space, and some re-organization to make comparisons between each yaml easier.
Opps, it is a draft PR... |
…e wind to windEast/Northward, respectively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
1c34239
After reviewing the YAML files I'm currently using for my FV3JEDI case, I've noticed inconsistencies in the data types for station elevation and height across different files. I usually use integers for surface observations and floats for others. I'm not sure why this is the case, as these settings appear to be derived from the previous YAML examples provided by JCSDA. I will look into this issue further. |
@spanNOAA @guoqing-noaa @ShunLiu-NOAA @hu5970 @HuiLiu-NOAA, I know Sijie was going to look into the inconsistencies noted above. But I've reverted heights/stationElevation to integers and don't seem to have an issue at the moment--I can't reproduce the issue I thought I had before. If it comes up we can always just make that change later. Is there anything else anyone would like to see different? Otherwise, I think this PR is ready to go. |
Perhaps one thing could be a bash script that can help generate the ioda files using the yamls? Would that be something to add here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Let's consider adding a bufr2ioda ctest in another PR with including a bash script to generate the IODA files.
@delippi Have you ever looked at the bufr2ioda outputs? When I review my adpsfc output, I consistently find two values for each variable at the same location and time offset. Do you have any insights on this? Here’s a snippet of the obs:
|
@spanNOAA, I think that might be because wind is reported separately from the other variables. Check the corresponding ObsType with the NaN's. I bet they start with a 2. Here is a snip from the ioda_adpsfc_dc.nc:
|
…and added the conversion from hours, changed mesonetProvider to dataProviderOrigin, added dataProviderSubOrigin for mesonet as well, made various updates to unit labels to match the IODA convention.
I'm trying to follow this https://github.com/JCSDA-internal/ioda/blob/develop/share/ioda/yaml/validation/ObsSpace.yaml (which Praveen provided). |
This PR updates the bufr2ioda yaml configurations to address issues identified in the original files. Some of those issues include:
change height data type from int to float