-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make UPP works with Rocky 8 on CSPs #1034
base: develop
Are you sure you want to change the base?
Conversation
@weihuang-jedi Have you tested the UPP on CSPs with your PR? |
prepend_path("PATH", "/contrib/EPIC/bin") | ||
load("gnu") | ||
load("stack-intel") | ||
load("stack-intel-oneapi-mpi") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These loads should not be necessary as they are run below with versions specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weihuang-jedi Have you verified successful initial testing on CSPs with these updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FernandoAndrade-NOAA I have compiled on AWS with Rocky 8, but did not run others.
-- Installing: /contrib/Wei.Huang/dev/upp-cloud/install/lib/cmake/upp/upp-targets.cmake
-- Installing: /contrib/Wei.Huang/dev/upp-cloud/install/lib/cmake/upp/upp-targets-release.cmake
- rm -rf /contrib/Wei.Huang/dev/upp-cloud/exec
- mkdir -p /contrib/Wei.Huang/dev/upp-cloud/exec
- cp ../install/bin/upp.x /contrib/Wei.Huang/dev/upp-cloud/exec/.
Do you have suggestions to run some tests here?
Thanks,
Wei
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPP standalone RTs are currently not configured on CSPs, so a build test would be sufficient for this PR. I tested on AWS with Rocky 8 with no errors during the build, I will work on verifying Azure tomorrow.
Leaving a note here that I am unable to confirm successful builds on Azure and GCP due to allocation issues, I will leave updates once they're available again. |
As CSPs will totally move to Rocky 8 start 1/1/2024, we need to make sure UPP works with Rocky 8 before that day.
Fix issue: #1033