Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WAFS to GFSv17 workflow #15

Closed
YaliMao-NOAA opened this issue Nov 7, 2023 · 7 comments
Closed

Add WAFS to GFSv17 workflow #15

YaliMao-NOAA opened this issue Nov 7, 2023 · 7 comments

Comments

@YaliMao-NOAA
Copy link
Collaborator

YaliMao-NOAA commented Nov 7, 2023

Add WAFS to GFSv17 global ecflow.

  1. Merge wafs update for GFSv16 to wafs 'develop' branch
  2. Cleaned up WAFS legacy files that are no longer needed
  • Removed outdated fix/wafs parm/wafs files
  • Removed 1.25 hazard grib2 source code sorc/wafs_awc_wafavn.fd sorc/wafs_blending.fd sorc/wafs_setmissing.fd, updated sorc/build_wafs.sh sorc/CMakeLists.txt
  • Removed 1.25 hazard grib2 parts from parm/script/ush files
  • Removed 1.25 blend parm/script/ush file
  • Removed ICAO2023=no related lines, updated related scripts/ush
  • Removed GRIB octant related ush file and updated the script
  • Renamed some fix files for better organizing the fix filenames
  1. EIB will update cmake in WAFS develop
  2. Add jobs, scripts and ush to GFS v17 workflow repository
  3. EIB will update one WAFS J-job as a demonstration
  4. Update other WAFS J-jobs accordingly with EIB’s help

Update reminders:

  1. Blend US own product if UK unblended data misses the waiting time window
  2. UPP remove output on ICAO standard atmospheric levels
  3. Switch VVEL to dzdt
  4. May be merged with issue GCIP update for NESDIS satellite upgrade #14
  5. Update forecat hour from 2 digits to 3 digits, as addressed in issue Some WAFS files are still using fHH instead of fHHH #11
@YaliMao-NOAA
Copy link
Collaborator Author

@HuiyaChuang-NOAA
We are exploring to apply 'near neighbor' interpolation to CB, instead of 'linear' interpolation.

@YaliMao-NOAA YaliMao-NOAA changed the title Separate WAFS from global ecflow Add WAFS to GFSv17 workflow Mar 15, 2024
@YaliMao-NOAA
Copy link
Collaborator Author

  1. Merge wafs update for GFSv16 to wafs 'develop' branch
    717233b

@YaliMao-NOAA
Copy link
Collaborator Author

As to step 2, PR #19 is merged.
2. Cleaned up WAFS legacy files that are no longer needed

  • Removed outdated fix/wafs parm/wafs files
  • Removed 1.25 hazard grib2 source code sorc/wafs_awc_wafavn.fd sorc/wafs_blending.fd sorc/wafs_setmissing.fd, updated sorc/build_wafs.sh sorc/CMakeLists.txt
  • Removed 1.25 hazard grib2 parts from parm/script/ush files
  • Removed 1.25 blend parm/script/ush file
  • Removed ICAO2023=no related lines, updated related scripts/ush
  • Removed GRIB octant related ush file and updated the script
  • Renamed some fix files for better organizing the fix filenames
    Updated drivers for GFSv16.3 after this clean-up

As a based line, I ran a set of wafs data which were bit-wise identical to the operational products except one GCIP file which depends DCOM METAR observation accumulative data.

@aerorahul WAFS is ready for you to update CMake related parts. Thank you for your help.

@YaliMao-NOAA
Copy link
Collaborator Author

  1. EIB will update cmake in WAFS develop
    It's done in PR Initial clean-up in preparation for merging to global-workflow #20

@YaliMao-NOAA
Copy link
Collaborator Author

YaliMao-NOAA commented Mar 19, 2024

@aerorahul In global workflow, should I delete the ignored llines related to WAFS in .gitignore?

The lines should be related to jobs/scripts/ush, not parm

@YaliMao-NOAA
Copy link
Collaborator Author

  1. Add jobs, scripts and ush to GFS v17 workflow repository
    @aerorahul
    I simply copied WAFS jobs/scripts/ush to GFS v17 workflow, and made a PR #2412. Please let me know if I am not doing the right thing.
    For the next step, may you please help to get jobs/JGFS_ATMOS_WAFS_GRIB2 to work?

@aerorahul
Copy link
Contributor

This should be closed as WAFS will not be going to GFSv17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants