Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove auto push to docker hub in actions #9

Open
MinsukJi-NOAA opened this issue Dec 10, 2020 · 2 comments
Open

Remove auto push to docker hub in actions #9

MinsukJi-NOAA opened this issue Dec 10, 2020 · 2 comments

Comments

@MinsukJi-NOAA
Copy link
Collaborator

The auto push to docker hub in actions workflow will be removed for the following reasons:

  • It appears that pull requests initiated by developers do not have permission to access secrets required to push to docker hub in actions
  • It's not a good idea to push to docker hub every time a PR is made.

One issue for this removal is how to maintain the docker hub images up to date with the changes in this repository. This will be addressed separately.
MinsukJi-NOAA added a commit to MinsukJi-NOAA/emc-containers that referenced this issue Dec 11, 2020
@MinsukJi-NOAA
Remove auto push docker hub in actions (NOAA-EMC#9)
842eba1
@MinsukJi-NOAA MinsukJi-NOAA mentioned this issue Dec 11, 2020
Merged
@aerorahul
Copy link
Contributor

I reverted the pr #10 since it failed the CI.

@MinsukJi-NOAA
Copy link
Collaborator Author

Thanks. It seems that the error stems from trying to get the udunits.tar.gz. I will update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aerorahul @MinsukJi-NOAA