Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needed Fix to aux2d Dimensions #834

Open
drnimbusrain opened this issue May 13, 2024 · 0 comments
Open

Needed Fix to aux2d Dimensions #834

drnimbusrain opened this issue May 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@drnimbusrain
Copy link

drnimbusrain commented May 13, 2024

Description

There is a bug in dimension definition for the 2D auxiliary array.

This can only be identified if a user only wants to output 2D auxilarly arrays, and will face CCPP prebuild errors that clearly show the inconsistency.

    raise Exception('Dimension {}, required by variable {}, not defined in host model metadata'.format(
Exception: Dimension number_of_3d_auxiliary_arrays, required by variable auxiliary_2d_arrays, not defined in host model metadata

This bug exists in the CCPP auxiliary ReadTheDocs in the section describing needed meta file changes for ccpp related codes:

https://ccpp-techdoc.readthedocs.io/en/latest/ParamSpecificOutput.html#output-of-auxiliary-arrays-from-ccpp
image

To fix the bug, a change is needed to the following file:

ccpp/data/GFS_typedefs.meta

Proposed Change (in bold below)

[aux2d]
standard_name = auxiliary_2d_arrays
long_name = auxiliary 2d arrays to output (for debugging)
units = none
dimensions = (horizontal_loop_extent,number_of_xy_dimensioned_auxiliary_arrays)
type = real
kind = kind_phys
active = (number_of_xy_dimensioned_auxiliary_arrays > 0)

Output

    raise Exception('Dimension {}, required by variable {}, not defined in host model metadata'.format(
Exception: Dimension number_of_3d_auxiliary_arrays, required by variable auxiliary_2d_arrays, not defined in host model metadata

Testing:

  1. Have you tested the code changes? On what platforms?
    RDHPCs Hera

  2. Have you run regression test in ufs-weather-model or ufs-s2s-model with code changes?
    No, not needed.

Dependent PRs:

#833

@drnimbusrain drnimbusrain added the bug Something isn't working label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant