Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocean variable to ocean post-processing #85

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

EricSinsky-NOAA
Copy link
Contributor

@EricSinsky-NOAA EricSinsky-NOAA commented Oct 8, 2024

Description

Tob has been added to the ocean variables for ocean post-processing. Tob is a variable that has been requested in the GEFS products.

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

This has been tested using the GEFS CI test case on WCOSS2.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

Tob has been added to the ocean variables for ocean post-processing.
@EricSinsky-NOAA
Copy link
Contributor Author

It looks like tob is the only variable that needs to be added for post-processing. Marking as ready for review.

@aerorahul aerorahul merged commit 856a420 into NOAA-EMC:develop Oct 10, 2024
3 checks passed
@EricSinsky-NOAA EricSinsky-NOAA deleted the feature/addocnvars branch October 10, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants