Add components for converting satwnd amv goes data from bufr dump to ioda. #13
Conversation
emilyhcliu
assigned rmclaren, xincjin-NOAA and nicholasesposito and unassigned rmclaren, nicholasesposito and xincjin-NOAA
emilyhcliu
requested review from
CoryMartin-NOAA,
xincjin-NOAA and
nicholasesposito
| @@ -0,0 +1,58 @@ | |||
| time window: | |||
| begin: "2018-04-14T21:00:00Z" | |||
There was a problem hiding this comment.
just noting that we will want to template these if they are not in a fixed 'test' directory
ush/test/README.md
Outdated
| ./build.sh | ||
| ``` | ||
|
|
||
| - Clone wxflow (no need to build) |
There was a problem hiding this comment.
Let me include wxflow in the obsForge clone
ush/test/bufr2ioda.sh
Outdated
| @@ -0,0 +1,206 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
general question, @emilyhcliu , do we want to set up ctests so that a user just needs to run ctest to test like we do for JEDI repos?
There was a problem hiding this comment.
Yes. We will add CTests in obsForge.
ush/test/README.md
Outdated
|
|
||
| bufr2ioda.sh "" "" "" "" "" script2netcdf" 0 | ||
|
|
||
| bufr2ioda.sh "" "" "" "" "" bufr_backend" 12 |
There was a problem hiding this comment.
Can we use named inputs? Otherwise, in order to give the final input we have to type all others.
There was a problem hiding this comment.
@rmclaren Should the script "bufr2ioda.sh" be called "bufr2netcdf.sh"?
This test script can handle four cases with or without MPI.
- bufr2netcdf (bufr-query)
- scrtip2netcdf (bufr-query)
- bufr_backend (bufr-query+ioda)
- script2_backend (bufr-query+ioda)
It covers tests for bufr-query and ioda. Do you have any suggestion for a better name?
This is a shell script to help team members test their converters.
We will add CTESTs for these tests in obsForge.
|
@emilyhcliu Dunno, maybe encodeBufr.sh or runBufr.sh (since we it for testing the second option might make sense (?). |
I will use |
|
|
||
| end_time = time.time() | ||
| running_time = end_time - start_time | ||
| logging(comm, 'INFO', f'Total running time: {running_time}') |
There was a problem hiding this comment.
Should we consider adding runtimes to the all subroutines in case we're curious if there are hang ups?
| - Get the help page for usage | ||
|
|
||
| ``` | ||
| bufrioda.sh -h |
|
|
||
| ./build.sh | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Recommend adding here a line saying to mkdir a testinput directory in sorc/spoc/ush/test and also moving your input file here. The encodeBufr.sh does not do this (though it does make testoutput). Might be worth having encodeBufr.sh doing it too.
| # =============== | ||
| # Set file paths | ||
| # =============== | ||
| ioda_config_yaml="${work_dir}/bufr2ioda_${mode}_${obstype}.yaml" |
There was a problem hiding this comment.
Suggest adding lines to move the appropriate files to the work_dir from their original locations. Written as is, the script looks for ioda_config_yaml, mapping_file, and input_file which are not already there.
Add components for converting satwnd amv goes data from bufr dump to ioda.
dump/mapping
dump/config
/ush/test
Notes: The test shell script (bufr2ioda.sh) can test the following for each obs type: