Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mppnccombine needs update to use the input format by default #319

Open
ceblanton opened this issue Oct 22, 2024 · 1 comment
Open

mppnccombine needs update to use the input format by default #319

ceblanton opened this issue Oct 22, 2024 · 1 comment
Assignees

Comments

@ceblanton
Copy link
Contributor

ceblanton commented Oct 22, 2024

Describe the bug
mppnccombine supports Netcdf-3 classic, Netcdf-3 64-bit offset, and Netcdf-4 input file and output file formats.

The FRE team believed that if you specify the output format (i.e. -64 or -n4), then the tool will use the format. Otherwise, it should use the input format.

Unfortunately, this is not how the tool works. How it works is: If you specify the output format (-64 or -n4), then the tool will use that format (Netcdf-3 64-bit offset and Netcdf-4 classic). But if the output format is not specified, then the default is Netcdf-3 classic.

To Reproduce
Find some test input files and convert them so both Netcdf-4 and Netcdf-3 64-bit offset are available.

Run mppncombine without specifying the output format, and observe the behavior.

In both cases, the tool chooses the never-desired Netcdf-3 classic format.

(use ncdump -k to see the file type)

Expected behavior
When the input files are either Netcdf-3 64-bit offset or regular Netcdf-3, and no output format is specified, then the output format should be Netcdf-3 64-bit offset.

When the input files are Netcdf-4 and no output format is specified, then the output format should be Netcdf-4.

System Environment
any

Additional context
Add any other context about the problem. If applicable, include where any files
that help describe, or reproduce the problem exist.

@ceblanton
Copy link
Contributor Author

@HansVahlenkamp, as the original and most recent mppnccombine maintainer, could you fix this? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants