Trouble with harmonic analysis in some tests

[kshedstrom]

I'm getting seg fault - invalid memory reference with this stack trace:

 0 0x0000000000012cf0 __funlockfile()  :0
 1 0x0000000000909128 __mom_harmonic_analysis_MOD_ha_accum_ftssh()  //import/c1/AKWATERS/kate/ESMG/ESMG-configs/src/MOM6/src/diagnostics/MOM_harmonic_analysis.F90:244
 2 0x000000000097640f __mom_barotropic_MOD_btstep()  //import/c1/AKWATERS/kate/ESMG/ESMG-configs/src/MOM6/src/core/MOM_barotropic.F90:2559
 3 0x00000000010f2db7 __mom_dynamics_split_rk2_MOD_step_mom_dyn_split_rk2()  //import/c1/AKWATERS/kate/ESMG/ESMG-configs/src/MOM6/src/core/MOM_dynamics_split_RK2.F90:917
 4 0x00000000008f0441 __mom_MOD_step_mom()  //import/c1/AKWATERS/kate/ESMG/ESMG-configs/src/MOM6/src/core/MOM.F90:1256
 5 0x00000000008f0441 __mom_MOD_step_mom()  //import/c1/AKWATERS/kate/ESMG/ESMG-configs/src/MOM6/src/core/MOM.F90:921
 6 0x00000000010c7244 __ocean_model_mod_MOD_update_ocean_model()  //import/c1/AKWATERS/kate/ESMG/ESMG-configs/src/MOM6/config_src/drivers/FMS_cap/ocean_model_MOM.F90:610
 7 0x0000000000fef9d7 MAIN__()  //import/c1/AKWATERS/kate/ESMG/ESMG-configs/src/coupler/full/coupler_main.F90:1064
 8 0x0000000000407fed main()  //import/c1/AKWATERS/kate/ESMG/ESMG-configs/src/coupler/full/coupler_main.F90:335
 9 0x000000000003ad85 __libc_start_main()  ???:0

I don't recall asking for a harmonic analysis and it seems to have been only partially initialized.

[kshedstrom]

My little Supercritical test has the same stack trace.

[kshedstrom]

I'm renaming this issue. It appears that HAready is set to default true. It can be set to false in HA_init, which is called from tidal_forcing_init, but only if CS%use_tides is true. The Supercritical case has no tides. I'm not sure why other non-tidal cases don't have this issue.

[c2xu]

Thanks for raising this issue. I'm not quite sure why it would happen, but I agree that HAready should be set to default false. I'll also make some additional adjustment to make sure that harmonic analysis is not activated if tide is not used.