Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline harmonic analysis #719

Open
c2xu opened this issue Sep 6, 2024 · 2 comments
Open

Inline harmonic analysis #719

c2xu opened this issue Sep 6, 2024 · 2 comments

Comments

@c2xu
Copy link

c2xu commented Sep 6, 2024

  1. Currently, the harmonic analysis does not have the restart capability to span multiple run segments.
  2. Array indexing should be more consistent with that in the model, e.g., using hor_index_type to specify the dimensions.
  3. The use of harmonic analysis should be specified by a logic flag, instead of relying on parameters inside the module.
  4. Revisit the use of local variable instead of pointer for the control structure.
@c2xu
Copy link
Author

c2xu commented Sep 14, 2024

  1. The subroutine HA_init is called from the subroutine tidal_forcing_init, but it seems that in regional models tides can be forced from open boundaries only without enabling astronomical tidal forcing.

@c2xu
Copy link
Author

c2xu commented Oct 31, 2024

  1. Right now only one accumulator of FtF is implemented (at each baroclinic time step) and is shared between all FtSSH. This would become problematic if some FtSSH is accumulated at different time steps (e.g., the barotropic time step).
  2. Also, the harmonic analysis doesn't really need such a high temporal resolution. Instead of each baroclinic time step, they can be called at, e.g., each hour. It might be more convenient to have a user-specified sampling frequency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant