Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holland and Jenkins melt parameterisation issues #67

Open
claireyung opened this issue Sep 4, 2023 · 0 comments
Open

Holland and Jenkins melt parameterisation issues #67

claireyung opened this issue Sep 4, 2023 · 0 comments

Comments

@claireyung
Copy link

Hello,

I found some issues in the MOM6 ice shelf melt parameterisation module (a missing von Karman constant in the definition of ZETA_N, buoyancy iteration loop that doesn't progress and salt iteration overriding the false position method) which were explained and addressed in PR NOAA-GFDL/MOM6#395. I believe the same bugs are present in the iceberg melt code:

Missing von Karman constant in ZETA_N: https://github.com/NOAA-GFDL/icebergs/blob/dev/gfdl/src/icebergs.F90#L3514
Buoyancy iteration loop doesn't update: https://github.com/NOAA-GFDL/icebergs/blob/dev/gfdl/src/icebergs.F90#L3697
Salt iteration overrides false position method a line earlier: https://github.com/NOAA-GFDL/icebergs/blob/dev/gfdl/src/icebergs.F90#L3755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant