Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cb-ceiling - merge middleware code for multiple plot types #1036

Open
gopa-noaa opened this issue Aug 3, 2023 · 6 comments
Open

cb-ceiling - merge middleware code for multiple plot types #1036

gopa-noaa opened this issue Aug 3, 2023 · 6 comments
Assignees
@mollybsmith-noaa
Labels
Couchbase MATS An issue affecting the MATS project MATScommon An issue affecting the MATScommon project task An actionable item of work

Comments

@gopa-noaa
Copy link
Contributor

Currently each plot type is handled by separate modules, with some shared code in matsMiddle_common.js
There is potential to merge 2 or more of these modules into a single module.
@gopa-noaa gopa-noaa added task An actionable item of work Couchbase MATS An issue affecting the MATS project MATScommon An issue affecting the MATScommon project labels Aug 3, 2023
@gopa-noaa gopa-noaa self-assigned this Aug 3, 2023
@gopa-noaa gopa-noaa mentioned this issue Aug 3, 2023
Closed
3 tasks
gopa-noaa pushed a commit that referenced this issue Aug 3, 2023
created issue #1036 to work on merge code, this push works without th…
0d632ce 
…e merge code
@gopa-noaa
Copy link
Contributor Author

Note to myself: this is partially implemented in matsMiddle_ts_dieoff.js

gopa-noaa pushed a commit that referenced this issue Sep 6, 2023
partial merge - merge middleware code for multiple plot types #1036
e348096
@gopa-noaa gopa-noaa mentioned this issue Sep 6, 2023
Closed
@gopa-noaa gopa-noaa linked a pull request Sep 6, 2023 that will close this issue
Cb ceiling middle tier plots #1050
Closed
@gopa-noaa gopa-noaa removed a link to a pull request Sep 6, 2023
Cb ceiling middle tier plots #1050
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the Stale label Dec 7, 2023
@mollybsmith-noaa
Copy link
Collaborator

I've made some progress towards this by enabling averaging support in the timeseries middleware. They're now all aggregating over a query-dependent field, so we can combine them into one function that aggregates over a generic "independentVar".

@github-actions github-actions bot removed the Stale label Jan 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 6, 2024

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the Stale label Apr 6, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the Stale label Jul 10, 2024
@mollybsmith-noaa
Copy link
Collaborator

The various middleware codes are now all in the same format as one another, so the only thing that remains is to actually combine them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mollybsmith-noaa mollybsmith-noaa

Labels
Couchbase MATS An issue affecting the MATS project MATScommon An issue affecting the MATScommon project task An actionable item of work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mollybsmith-noaa @gopa-noaa