Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ngen.init_config.GenericSerializerDeserializer in ngen.config_gen #179

Closed
aaraney opened this issue Aug 26, 2024 · 1 comment · Fixed by #184
Closed

Add support for ngen.init_config.GenericSerializerDeserializer in ngen.config_gen #179

aaraney opened this issue Aug 26, 2024 · 1 comment · Fixed by #184
Assignees
@aaraney
Labels
enhancement New feature or request feat New software feature; Not build script / CI feature ngen.config_gen Related to ngen.config_gen package

Comments

@aaraney
Copy link
Member

aaraney commented Aug 26, 2024

See #178
@aaraney aaraney added enhancement New feature or request ngen.config_gen Related to ngen.config_gen package feat New software feature; Not build script / CI feature labels Aug 26, 2024
@aaraney aaraney self-assigned this Aug 26, 2024
@aaraney
Copy link
Member Author

aaraney commented Aug 26, 2024

These two code paths will need to be updated:

ngen-cal/python/ngen_config_gen/src/ngen/config_gen/file_writer.py

Line 67 in 6b35dd4

def _get_serializer(data: BaseModel) -> Callable[[Path], None]:

ngen-cal/python/ngen_config_gen/src/ngen/config_gen/file_writer.py

Line 90 in 6b35dd4

def _get_file_extension(data: BaseModel) -> str:

@aaraney aaraney mentioned this issue Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaraney aaraney

Labels
enhancement New feature or request feat New software feature; Not build script / CI feature ngen.config_gen Related to ngen.config_gen package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: write support for GenericSerializer aaraney/ngen-cal
1 participant
@aaraney