Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngen_cal_model_configure is called after ngen_cal_model_observations is called #201

Open
aaraney opened this issue Sep 25, 2024 · 1 comment
Open

ngen_cal_model_configure is called after ngen_cal_model_observations is called #201

aaraney opened this issue Sep 25, 2024 · 1 comment
Assignees
@aaraney
Labels
bug Something isn't working ngen.cal Related to ngen.cal package

Comments

@aaraney
Copy link
Member

aaraney commented Sep 25, 2024

ngen-cal/python/ngen_cal/src/ngen/cal/__main__.py

Line 90 in e3017a3

agent = Agent(model, general.workdir, general.log, general.restart, general.strategy.parameters)

During Agent initialization, a CalibrationSet instance is created. CalibrationSet calls ngen_cal_model_observations in its initializer.
@aaraney aaraney added bug Something isn't working ngen.cal Related to ngen.cal package labels Sep 25, 2024
@aaraney
Copy link
Member Author

aaraney commented Sep 25, 2024

@ajkhattak found this (thanks for reporting it to me! 🎉)

@aaraney aaraney self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaraney aaraney

Labels
bug Something isn't working ngen.cal Related to ngen.cal package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaraney