Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weaken type requirements of pluggin_settings fields #202

Open
aaraney opened this issue Sep 26, 2024 · 0 comments
Open

Weaken type requirements of pluggin_settings fields #202

aaraney opened this issue Sep 26, 2024 · 0 comments
Assignees
@aaraney
Labels
enhancement New feature or request ngen.cal Related to ngen.cal package

Comments

@aaraney
Copy link
Member

aaraney commented Sep 26, 2024

ngen-cal/python/ngen_cal/src/ngen/cal/model.py

Line 271 in 2823b2c

plugin_settings: Dict[str, Dict[str, Any]] = Field(default_factory=dict)

I don't see a reason why this shouldnt be pluggin_settings: Dict[str, Any]. This should be changed for both model and general plugins.
@aaraney aaraney added enhancement New feature or request ngen.cal Related to ngen.cal package labels Sep 26, 2024
@aaraney aaraney self-assigned this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaraney aaraney

Labels
enhancement New feature or request ngen.cal Related to ngen.cal package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaraney