Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify units of dx and dy as returned by bmi_noahowp%get_grid_spacing #101

Open
GreyREvenson opened this issue Mar 11, 2024 · 1 comment

Comments

@GreyREvenson
Copy link
Contributor

Current behavior

Calling bmi_noahowp%get_grid_spacing returns (/model%domaingrid%dy, model%domaingrid%dx/) (i.e., via bmi_grid%spacing). This behavior is consistent with BMI 2.0 specifications. However, as the units of dx and dy are not specified in the BMI 2.0 documentation, there is ambiguity regarding the appropriateness of the current implementation.

When executed in standalone (outside NextGen), dx and dy are read-into the model via the required domain attributes NetCDF file (which is expected to have global attributes dx and dy). The example attributes file (i.e., data/NorthForkAttributes.nc) contains a subset of the NWM 3.0 grid for the North Fork (WY) CAMELS test basin; hence, dx = dy = 1 km.

Suggested changes

Verify current implementation of bmi_noahowp%get_grid_spacing or amend implementation of dx and dy as needed.

@GreyREvenson
Copy link
Contributor Author

@drakest123 Care to expand upon or edit this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant