Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TBOT conflict and hard-coded values #114

Open
SnowHydrology opened this issue Aug 29, 2024 · 1 comment
Open

Fix TBOT conflict and hard-coded values #114

SnowHydrology opened this issue Aug 29, 2024 · 1 comment

Comments

@SnowHydrology
Copy link
Contributor

This line uses forcing%tbot, which is different than the parameters%tbot here.

BOTH VALUES ARE HARD-CODED—YIKES—AND DIFFERENT.

Forcing:

noah-owp-modular/src/RunModule.f90

Line 182 in 5be0faa

forcing%TBOT = 285.0 ! bottom condition for soil temperature [K]

Parameters:

noah-owp-modular/src/ParametersType.f90

Line 361 in 5be0faa

this%TBOT = 263.0 ! (K) can be updated depending on option OPT_TBOT

@SnowHydrology
Copy link
Contributor Author

Note: Noah-MP defines TBOT as a static attribute per grid cell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SnowHydrology