New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert datetime handling from strings to unix-time based internal variable #16

Open

andywood opened this issue Sep 14, 2021 · 4 comments

Contributor

andywood commented Sep 14, 2021

current date/time handling is based on strings, which is brittle and prevents using most fortran time utilties and conventions

Contributor

SnowHydrology commented Sep 14, 2021

Agreed that this would be useful, but let's chart out a strategy that prioritizes the following:

Changes to one module are easily portable to another module
Noah-MP-Modular enhancements do not duplicate Nextgen functionality

Contributor

SnowHydrology commented Nov 18, 2021

@andywood, do your commits from PR 30 close this issue?

Contributor Author

andywood commented Nov 23, 2021 via email

Not quite - there are a lot of string-based operations still in the ATM module, I think -- these would be much simpler after switching to unix times.

On Thu, Nov 18, 2021 at 8:51 AM K. Jennings ***@***.***> wrote: @andywood <https://github.com/andywood>, do your commits from PR 30 <#30> close this issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIKARP6WP4ZJEU6UVQKF23UMUOHNANCNFSM5EAM2FUQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

Contributor

SnowHydrology commented Nov 23, 2021

That makes sense. I'll leave this open for now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment