Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I want system testing to be modified so that it can be executed from within GitHub #31

Open
HankHerr-NOAA opened this issue Jul 8, 2024 · 2 comments

Comments

@HankHerr-NOAA
Copy link
Contributor

System testing is currently still executed on NWC machines, even though we develop in GitHub, largely because the system tests require large datasets that cannot be readily stored within, or close to, the GitHub repository. Allowing for system testing to be run within a GitHub workflow will require adjusting the system tests appropriately to still do what we want them to do but with data that can be obtained to support a GitHub workflow.

This ticket can be resolved once we've modified the system testing to allow for it to be run within a GitHub workflow.

Thanks,

Hank

@HankHerr-NOAA
Copy link
Contributor Author

I created this ticket largely so that I can reference a point made by Chris:

If you guys have zarr or S3 support you might be able to use some of the cloud services that GID has set up. https://console.cloud.google.com/marketplace/product/noaa-public/national-water-model

It would need to be a stable archive that could be relied upon to support system testing for years to come, and I'm always leery about external dependencies (including USGS NWIS, by the way), but that would allow for us to use large datasets without needing to store them in GitHub.

Hank

@epag
Copy link
Collaborator

epag commented Jul 8, 2024

There are for sure github actions that allow interfacing with s3 buckets if we wanted to do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants