Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, if I provide a valid_dates range, I expect event detection to constrain itself to that range of dates #388

Open
HankHerr-NOAA opened this issue Jan 24, 2025 · 0 comments
Labels
enhancement New feature or improvement

Comments

@HankHerr-NOAA
Copy link
Contributor

See #382. Specifically,

#382 (comment)

I saw evidence that the valid_dates was being ignored in an evaluation that included event_detection. I expected that the WRES would only include events detected within that range (I was trying to look at output for only 2 or 3 events to make it easier to inspect). However, it seeming ignored the valid_dates and gave me all of the usual events. In fact, I saw no output at all related to that valid_dates range; it appeared to ignore it altogether.

This ticket can be closed once the event_detection algorithm is applied to only the valid_dates range when a valid_dates is provided in the declaration.

Thanks,

Hank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

1 participant