Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_key_def(): unnecessary logging polutes stderr #513

Open
remtav opened this issue May 3, 2023 · 0 comments
Open

get_key_def(): unnecessary logging polutes stderr #513

remtav opened this issue May 3, 2023 · 0 comments

Comments

@remtav
Copy link
Collaborator

remtav commented May 3, 2023

https://github.com/NRCan/geo-deep-learning/blob/develop/utils/utils.py#L169

    if not val:  # Skips below if statements if val is None
        logging.error(f"The key {key} as a None value.")

The "val" variable may be None without it being an error. This logging message appears over and over during inference, for example. I'd suggest removing this logging altogether.

@CharlesAuthier this was added in your PR: https://github.com/NRCan/geo-deep-learning/pull/478/files#diff-9653b8c2ce917a6134298b00c8b3f7d4b7c4dc473a752303f37a870392742127R167
any particular use for this error message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant