Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use More Semantically Appropriate Null Values #1045

Open
GabrielKS opened this issue Jan 22, 2024 · 0 comments
Open

Use More Semantically Appropriate Null Values #1045

GabrielKS opened this issue Jan 22, 2024 · 0 comments

Comments

@GabrielKS
Copy link
Contributor

At

if isempty(bus_reduction_map)
,
if isempty(radial_network_reduction)
, and
if isempty(radial_network_reduction)
, we have special cases for when a particular dictionary is empty. The empty dictionary is being used as a null value, but nothing would be a better semantic match: we're not just trying to indicate that we should run the algorithm with zero bus reduction mappings, for example; we're trying to indicate that we should run a different version of the algorithm that takes its input from a different data structure. There are likely other occurrences of this elsewhere in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant