Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrects crash in DOAS fan sizing #10816

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Corrects crash in DOAS fan sizing #10816

wants to merge 7 commits into from

Conversation

rraustad
Copy link
Contributor

@rraustad rraustad commented Nov 7, 2024 •
edited
Loading

Pull request overview

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@rraustad rraustad added the Defect Includes code to repair a defect in EnergyPlus label Nov 7, 2024
rraustad
rraustad commented Nov 7, 2024
View reviewed changes
src/EnergyPlus/Autosizing/SystemAirFlowSizing.cc
} else {
this->autoSizedValue = this->finalSysSizing(this->curSysNum).DesOutAirVolFlow;
}
} else {
Copy link
Contributor Author

@rraustad rraustad Nov 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change is from here to line 780 above. The below is just git confusion.

@rraustad
Copy link
Contributor Author

rraustad commented Nov 7, 2024

The defect file now runs, and shows confusing fan sizing, since both fans are autosize, as:

image

And the peak day is of course blank:

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

⚠️ Regressions detected on macos-14 for commit cf547a0

Regression Summary
  • EIO: 3
  • MTR Big Diffs: 1
  • Table Big Diffs: 3
  • Table String Diffs: 2
  • ESO Big Diffs: 1

@rraustad
Copy link
Contributor Author

rraustad commented Nov 7, 2024

The DOAS fans are being read in as autosize

image

but when the extract fan gets to sizing it is set to a hard flow rate. I can't find where this is happening. The DOAS supply fan doesn't have this issue and sizes normally for an autosized fan (i.e., the first table here).

image

@rraustad
Copy link
Contributor Author

rraustad commented Nov 7, 2024

OK, the extract fan flow is getting set here, but I don't understand the timing or why this needs to be done. The supply fan doesn't get called in this order.

image

@rraustad rraustad added this to the EnergyPlus 25.1 milestone Nov 7, 2024
@rraustad
Copy link
Contributor Author

rraustad commented Nov 8, 2024

If I comment out line 997 I get:

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

⚠️ Regressions detected on macos-14 for commit b4d8e7a

Regression Summary
  • EIO: 4
  • MTR Big Diffs: 1
  • Table Big Diffs: 3
  • Table String Diffs: 2
  • ESO Big Diffs: 1

@nrel-bot-2
Copy link

@rraustad it has been 13 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@rraustad it has been 7 days since this pull request was last updated.

2 similar comments
@nrel-bot-2c
Copy link

@rraustad it has been 7 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@rraustad it has been 7 days since this pull request was last updated.

mjwitte
mjwitte approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@mjwitte mjwitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. Unit tests all pass. Thanks @rraustad Will merge after CI completes another round.

@github-actions GitHub Actions
Copy link

⚠️ Regressions detected on macos-14 for commit 1e85ef2

Regression Summary
  • EIO: 4
  • MTR Big Diffs: 1
  • Table Big Diffs: 3
  • Table String Diffs: 2
  • ESO Big Diffs: 1

@github-actions GitHub Actions
Copy link

⚠️ Regressions detected on macos-14 for commit 1e2ebf8

Regression Summary
  • EIO: 4
  • MTR Big Diffs: 1
  • Table Big Diffs: 3
  • Table String Diffs: 2
  • ESO Big Diffs: 1

@mjwitte
Copy link
Contributor

mjwitte commented Dec 20, 2024

@rraustad Is this kind of diff expected?
image

@rraustad
Copy link
Contributor Author

@mjwitte I will have to look at that file.

@github-actions GitHub Actions
Copy link

⚠️ Regressions detected on macos-14 for commit 053269e

Regression Summary
  • Table String Diffs: 2
  • EIO: 1

@github-actions GitHub Actions
Copy link

⚠️ Regressions detected on macos-14 for commit 023eb8a

Regression Summary
  • EIO: 1

@rraustad
Copy link
Contributor Author

rraustad commented Dec 22, 2024 •
edited
Loading

@mjwitte this is clean now. The 1 diff in SmallOffice_CentralDOAS is because the autosizing of the fan is not stomped on by the AirloopHVACDOAS code.

AirLoopHVAC:DedicatedOutdoorAirSystem,
  AirLoopHVAC DOAS,        !- Name
  AirLoopDOAS OA system,   !- AirLoopHVAC:OutdoorAirSystem Name

AirLoopHVAC:OutdoorAirSystem,
  AirLoopDOAS OA system,   !- Name
  OA Sys 1 Controllers,    !- Controller List Name
  OA Sys 1 Equipment;      !- Outdoor Air Equipment List Name

AirLoopHVAC:OutdoorAirSystem:EquipmentList,
  OA Sys 1 Equipment,      !- Name
  Fan:SystemModel,         !- Component 1 Object Type
  OA Supply Fan,           !- Component 1 Name

Fan:SystemModel,
  OA Supply Fan,           !- Name
  Autosize,                !- Design Maximum Air Flow Rate {m3/s}

image

Code no longer writes to the fan object:

image

rraustad
rraustad commented Dec 22, 2024
View reviewed changes
src/EnergyPlus/Autosizing/SystemAirFlowSizing.cc
if (unitarysysEqSizing.CoolingAirFlow && unitarysysEqSizing.HeatingAirFlow) {
this->autoSizedValue = std::max(unitarysysEqSizing.CoolingAirVolFlow, unitarysysEqSizing.HeatingAirVolFlow);
if (this->autoSizedValue == unitarysysEqSizing.CoolingAirVolFlow) {
if (this->curOASysNum > 0) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a little weird to size the OA system fan using the air loop flow rate (instead of using DesOutAirVolFlow) but that's what happened before and is how the MaxOA gets sized for the OA controller.

mjwitte
mjwitte approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@mjwitte mjwitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Thanks @rraustad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjwitte mjwitte mjwitte approved these changes

Assignees
No one assigned
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
EnergyPlus 25.1
Development

Successfully merging this pull request may close these issues.

AirLoopHVAC:DedicatedOutdoorAirSystem vector issue in sizing
6 participants
@rraustad @nrel-bot-2 @nrel-bot-2c @mjwitte @nrel-bot @nrel-bot-2b