Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Error in Slab #10826

Open
Myoldmopar opened this issue Nov 19, 2024 · 5 comments
Open

Possible Error in Slab #10826

Myoldmopar opened this issue Nov 19, 2024 · 5 comments
Assignees
Labels
Defect Includes code to repair a defect in EnergyPlus Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc)

Comments

@Myoldmopar
Copy link
Member

While doing some other work, I noticed some Fortran error messages in the Decent CI log. An example is here: https://raw.githubusercontent.com/Myoldmopar/EnergyPlusBuildResults/9f3981920dd17a175391f0e93a8384e69ab0a715/_posts/DU24/2024-11-19-EnergyPlus-9f87d4e7c15105aada2285a4844f6808b5f4d148-x86_64-Linux-Ubuntu-24.04-gcc-13.2-results.html

Search for: "fortran runtime error" and you'll find 3 instances. Seems like Decent isn't catching them as errors either. Odd.

@jmarrec
Copy link
Contributor

jmarrec commented Dec 2, 2024

ctest -VV -R integration.SingleFamilyHouse_HP_Slab
UpdateCTestConfiguration  from :/Users/julien/Software/Others/EnergyPlus-build/DartConfiguration.tcl
UpdateCTestConfiguration  from :/Users/julien/Software/Others/EnergyPlus-build/DartConfiguration.tcl
Test project /Users/julien/Software/Others/EnergyPlus-build
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 565
    Start 565: integration.SingleFamilyHouse_HP_Slab

565: Test command: /opt/homebrew/bin/cmake "-DSOURCE_DIR=/Users/julien/Software/Others/EnergyPlus" "-DBINARY_DIR=/Users/julien/Software/Others/EnergyPlus-build" "-DENERGYPLUS_EXE=/Users/julien/Software/Others/EnergyPlus-build/Products/energyplus-25.1.0" "-DIDF_FILE=SingleFamilyHouse_HP_Slab.idf" "-DEPW_FILE=USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw" "-DENERGYPLUS_FLAGS= -D -r" "-DBUILD_FORTRAN=ON" "-DTEST_FILE_FOLDER=testfiles" "-DRUN_CALLGRIND:BOOL=FALSE" "-DVALGRIND=" "-DRUN_PERF_STAT:BOOL=FALSE" "-DPERF=" "-P" "/Users/julien/Software/Others/EnergyPlus/cmake/RunSimulation.cmake"
565: Working Directory: /Users/julien/Software/Others/EnergyPlus-build/testfiles
565: Test timeout computed to be: 10000000
565: Executing ExpandObjects from /Users/julien/Software/Others/EnergyPlus-build/Products/ExpandObjects
565: ExpandObjects Started.
565:  Begin reading Energy+.idd file.
565:  Done reading Energy+.idd file.
565: ExpandObjects Finished. Time:     0.040
565: Executing Slab from /Users/julien/Software/Others/EnergyPlus-build/Products/Slab
565:  Begin Ground Temp Calculations
565:  Completed Reading Weather File
565:  Auto Size Grid Selected
565:   Slab thickness reset to 0.122 m  for computational stability.
565:  Entering Main Computational Block
565:  Working on year            1
565:  Working on year            2
565:  Working on year            3
565:  Working on year            4
565:  Working on year            5
565:  Working on year            6
565:  Working on year            7
565:  Working on year            8
565: STOP GroundTempCalc Completed Successfully.
565: Executing Basement from /Users/julien/Software/Others/EnergyPlus-build/Products/Basement
565: At line 338 of file /Users/julien/Software/Others/EnergyPlus/src/Basement/InputProcessor.f90 (unit = 3)
565: Fortran runtime error: Cannot open file 'BasementGHTIn.idf': No such file or directory
565:
565: Error termination. Backtrace:
565: #0  0x1025680cf
565: #1  0x102568b97
565: #2  0x102569467
565: #3  0x1025743c3
565: #4  0x1025748df
565: #5  0x102565253
565: #6  0x102546bd3
565: #7  0x10259a80f
565: EnergyPlus Starting
565: EnergyPlus, Version 25.1.0-b9a992f2d2, YMD=2024.12.02 17:08
565: Initializing Response Factors
565: Calculating CTFs for "EXTERIOR WALL"
565: Calculating CTFs for "INTERIORFURNISHINGS"
565: Calculating CTFs for "INTERIOR FLOOR"
565: Calculating CTFs for "INTERIOR CEILING"
565: Calculating CTFs for "EXTERIOR ROOF"
565: Calculating CTFs for "EXTERIOR DOOR"
565: Calculating CTFs for "GABLE_END"
565: Initializing Window Optical Properties
565: Initializing Solar Calculations
565: Allocate Solar Module Arrays
565: Initializing Zone and Enclosure Report Variables
565: Initializing Surface (Shading) Report Variables
565: Computing Interior Solar Absorption Factors
565: Determining Shadowing Combinations
565: Computing Window Shade Absorption Factors
565: Proceeding with Initializ (...)

@jmarrec
Copy link
Contributor

jmarrec commented Dec 2, 2024

Seems like Decent isn't catching them as errors either

execute_process calls it. Unless you add COMMAND_ERROR_IS_FATAL or RESULT_VARIABLE, it doesn't care if it fails or not. https://cmake.org/cmake/help/latest/command/execute_process.html

I added that to #10843

@jmarrec
Copy link
Contributor

jmarrec commented Dec 2, 2024

The following files have at least GroundHeatTransfer:Basement object, but the GroundheatTransfer:Control says to not run the basement preprocessor.

  • EnergyPlus/testfiles/US+SF+CZ4A+hp+crawlspace+IECC_2006_VRF.idf
  • EnergyPlus/testfiles/SingleFamilyHouse_HP_Slab_Dehumidification.idf
  • EnergyPlus/testfiles/SingleFamilyHouse_HP_Slab.idf

Why? Does that make any sense? @Myoldmopar

@jmarrec jmarrec self-assigned this Dec 2, 2024
@jmarrec jmarrec added Defect Includes code to repair a defect in EnergyPlus Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc) labels Dec 2, 2024
@jmarrec
Copy link
Contributor

jmarrec commented Dec 3, 2024

SingleFamilyHouse_HP_Slab.idf and SingleFamilyHouse_HP_Slab_Dehumidification.idf

image

US+SF+CZ4A+hp+crawlspace+IECC_2006_VRF.idf

image

image

@jmarrec
Copy link
Contributor

jmarrec commented Dec 3, 2024

On my machine the crawlspace takes 39s with "Run Basement Preprocessor" to "no", and 111s with "yes" (basement takes 36s for year1, and 71s for year2).

Does seem like the IECC crawlspace was copied from the SingleFamily_HP_Slab one.

jmarrec added a commit that referenced this issue Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc)
Projects
None yet
Development

No branches or pull requests

2 participants