Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Project ENGIE Cleaning and Pandas Nested .loc Warning #270

Closed
RHammond2 opened this issue Feb 6, 2024 · 0 comments · Fixed by #272
Closed

Fix Project ENGIE Cleaning and Pandas Nested .loc Warning #270

RHammond2 opened this issue Feb 6, 2024 · 0 comments · Fixed by #272
Labels
bug enhancement maintenance Issues related to code maintainence. E.g., upgrading versions of dependencies, fixing the CI pipelie

Comments

@RHammond2
Copy link
Collaborator

There are two overlapping issues that can't be disentangled, and should be addressed simultaneously:

  1. Pandas will eventually stop supporting nested indexing as it cleans up its backend.
  2. In the v3 cleanup, a reassignment in a nested .loc was improperly removed see project_ENGIE.py:98.

Both should be rewritten to the form of, but in 2) the = np.nan is missing:

scada_df.loc[ix_flag.loc[ix_flag["<focal_column>"]].index, sensor_cols] = np.nan

The change in form won't the results, however, because in line 99 of the current file the assignment part of the expression is missing, our results will naturally change, and as a result, may be where some of our change in results earlier on were stemming from.

@RHammond2 RHammond2 added bug enhancement maintenance Issues related to code maintainence. E.g., upgrading versions of dependencies, fixing the CI pipelie labels Feb 6, 2024
@RHammond2 RHammond2 linked a pull request Feb 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement maintenance Issues related to code maintainence. E.g., upgrading versions of dependencies, fixing the CI pipelie
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant