You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In merging #888, the deploy-book action failed because I had forgotten to update some function calls in the TurbineInterface object on on floris/turbine_library/turbine_previewer.py. I've now patched this (I think) in #900
Looking into this more, the reason that I missed these is that TurbineInterface is not tested, and also not used in any of the examples.
I would suggest that we consider either:
Adding a test for the TurbineInterface or
Deprecating TurbineInterface and just going through the FlorisModel in the documentation (full deprecation would need to wait until a later major release)
The text was updated successfully, but these errors were encountered:
Based on this issue patched by #900 and the fact that it is only in documentation, it does seem reasonable to deprecate the functionality into FlorisModel, which will be more easily tracked
In merging #888, the deploy-book action failed because I had forgotten to update some function calls in the
TurbineInterface
object on on floris/turbine_library/turbine_previewer.py. I've now patched this (I think) in #900Looking into this more, the reason that I missed these is that
TurbineInterface
is not tested, and also not used in any of the examples.I would suggest that we consider either:
TurbineInterface
orTurbineInterface
and just going through theFlorisModel
in the documentation (full deprecation would need to wait until a later major release)The text was updated successfully, but these errors were encountered: