Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete multi-dim code #989

Open
5 tasks
paulf81 opened this issue Oct 1, 2024 · 2 comments
Open
5 tasks

Complete multi-dim code #989

paulf81 opened this issue Oct 1, 2024 · 2 comments
Assignees
Labels
documentation enhancement An improvement of an existing feature examples Changes to FLORIS examples

Comments

@paulf81
Copy link
Collaborator

paulf81 commented Oct 1, 2024

Complete multidim code

This issue picks up from issue #785 and proposes a set of steps to finish this work.

Proposed solution

Recommend to take the following steps (can iterate as we go):

  • Add example of applying multi-dim code to vary power by TI
  • Add tests of this same functionality
  • Include example of going to multidim via code versus from specially setup yaml
  • Add tests of same functionality?
  • Beef up a little bit multidim documentation
@misi9170
Copy link
Collaborator

misi9170 commented Oct 9, 2024

I'm working on this over on #996 . Generally speaking though, the multidimensional turbine code is not set up to take the turbulence_intensities keyword argument to FlorisModel.set() and pipe it through to the multidimensional power/thrust_coefficient table. Rather, the multidimensional power/thrust_coefficient table takes arbitrary keywords ("dimensions"), one of which could be "turbulence_intensity", "TI", etc. Those need to be specified separately to the turbulence_intensities passed to FlorisModel.set(). However, I've made setting the multidim_condition easier on #996 by allowing the user to specify it as a keyword argument to set(), for example:

fmodel.set(multidim_condition={"TI": 0.05}) # Assumes that TI is a column of the `power_thrust_data_file`

@paulf81
Copy link
Collaborator Author

paulf81 commented Oct 10, 2024

This solution makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement An improvement of an existing feature examples Changes to FLORIS examples
Projects
None yet
Development

No branches or pull requests

3 participants