Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scikit-learn version restriction < 1.6 #443

Open
martin-springer opened this issue Dec 12, 2024 · 1 comment
Open

Remove scikit-learn version restriction < 1.6 #443

martin-springer opened this issue Dec 12, 2024 · 1 comment

Comments

@martin-springer
Copy link
Collaborator

Describe the bug
Looks like scikit-learn just had a new release (https://scikit-learn.org/stable/whats_new/v1.6.html#version-1-6-0) and introduced a new tag sklearn_tags that seems to not yet work with xgboost.

Full error message and traceback
FAILED rdtools/test/filtering_test.py::test_xgboost_clip_filter - AttributeError: 'super' object has no attribute 'sklearn_tags'

To Reproduce
Run pytests with update strategy eager (as of 12/12/2024).

Expected behavior
No failed tests.

Additional context
This bug is most likely going to be fixed with the next update of xgboost and is mostly a reminder to remove the version restriction.

@martin-springer
Copy link
Collaborator Author

xgboost is aware of the issue: dmlc/xgboost#11093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant