Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Standard Data Release YAML to Integration Tests #1329

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from
Open

Conversation

afontani
Copy link
Contributor

@afontani afontani commented Dec 6, 2024

Pull Request Description

This pull request introduces the Standard Data Release (SDR) YAML file into the "develop" branch of ResStock and into GitHub Actions integration-tests. This PR will give contributors on the SDR measures a place to commit changes and aid in completing an end-to-end workflow in CI.

  • testing_upgrades and national_upgrades have been removed in favor of the sdr project file.
  • The tests have also been removed for testing_upgrades and national_upgrades
  • Similar tests as previously used in testing_upgrades and national_upgrades have been added for the SDR project file.

Area for improved testing

This PR is meant to introduce the SDR project file and do some elementary testing (similar to project national, project testing, and national upgrades). At this point, the tests make sure there is some data and columns. Improving the tests that exist today, building out functional tests, and regression testing are important areas for improvement moving forward. All the tests are currently in test/test_bsb_analysis.rb.

See

Related Pull Requests

None.

Related Issues

Closes #1261 -- "Commit ResStock 2024.2 data release yaml to develop"

Checklist

Required:

Optional (not all items may apply):

@afontani afontani self-assigned this Dec 6, 2024
@afontani afontani added this to the ResStock v3.5.0 milestone Dec 6, 2024
@joseph-robertson
Copy link
Contributor

Remove some tests? For example, remove national/testing upgrade ymls in favor of SDR upgrade yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit ResStock 2024.2 data release yaml to develop
2 participants