Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-coded rows and columns because this changes #78

Open
3 tasks
ambarb opened this issue Jul 14, 2021 · 1 comment
Open
3 tasks

Remove hard-coded rows and columns because this changes #78

ambarb opened this issue Jul 14, 2021 · 1 comment
Assignees

Comments

@ambarb
Copy link
Contributor

ambarb commented Jul 14, 2021

csxtools/csxtools/utils.py

Lines 318 to 319 in 52ff964

flat[120:250, 0:480] = np.nan
flat[:, 476:484] = np.nan

two options:

  • pass as arguments
  • look at fccd descriptors for epics plugin that reshapes the "live" image at the Beamline
  • not sure this is even used, so also add deprecation warning
 logger.warning("csxtools.utils.fccd_mask() planned for deprecation. Contact beamline staff ([email protected]) if you use this function.")
@ambarb ambarb self-assigned this Jul 14, 2021
@ambarb
Copy link
Contributor Author

ambarb commented May 23, 2024

on second thought, no one uses this function so we should just deprecate it along with 3D and 4D image functions because @danielballan fixed get_fastccd_images() to return the array instead of being a generator (simultaneously with tiled and dask integration #86)

@ambarb ambarb added the deprecation things to deprecate label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant