Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homework for new helpers modules #90

Open
4 tasks
ambarb opened this issue Jul 8, 2023 · 1 comment
Open
4 tasks

homework for new helpers modules #90

ambarb opened this issue Jul 8, 2023 · 1 comment
Assignees

Comments

@ambarb
Copy link
Contributor

ambarb commented Jul 8, 2023

Some minor work is needed.

Address bits of code that are less likely to fail in testing so far but could fail if conditions are met (flow control choices - most common seem to work ok)

As per @hyperrealist in #89

  • find_possible_darks() will run into an unhandled exception at this line if header.stop["exit_status"] == "abort" since exp_time will not be defined in that case.
  • Perhaps expected behavior, but find_possible_darks() may return a pandas DataFrame here or a python dictionary here depending on the execution path.

And then also:

  • find and remove unnecessary np.copy() from fccd.py and overscan.py
  • address if stop document does not get written to database - see comment below.

Far future for a new issue after this one is addressed:

  • Optimize further with tiled (should be faster searching and descriptors checking)
  • overscan.py optimization after testing is a seperate issue.
@ambarb ambarb self-assigned this Jul 18, 2023
@ambarb
Copy link
Contributor Author

ambarb commented Oct 30, 2023

another thing to add to the list is how to handle if the stop document DOES NOT EXIST. This can happen if someone tries to ^C a bluesky session AFTER RE.abort() or RE.stop(). Currently, the ^Z and killing the process is the only way to recover, and in that case, the stop document is never written to data store.
bluesky/bluesky#1626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant