You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The input validation stack between the spreadsheet and the command line do_rsoxs, do_nexafs functions appear to be different: polarizations=90 works in a spreadsheet but from command polarizations requires an Iterable such as a single-element list. It would provide a more consistent user experience to unify the input validation/cleanup code from rsoxs_scans such that the same parameters are accepted for both.
The text was updated successfully, but these errors were encountered:
In principle I think this is right, however, do_rsoxs and do_nexafs are not ever suggested to be used in general. spreadsheets have a validation step which these commands do not. There is an expectation that if a user is running the commands directly they should know inputs rather than trusting the running code to clean it up as with spreadsheet input.
The input validation stack between the spreadsheet and the command line
do_rsoxs
,do_nexafs
functions appear to be different:polarizations=90
works in a spreadsheet but from commandpolarizations
requires anIterable
such as a single-element list. It would provide a more consistent user experience to unify the input validation/cleanup code fromrsoxs_scans
such that the same parameters are accepted for both.The text was updated successfully, but these errors were encountered: