Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: inconsistent input validation between spreadsheet and commandline functions #33

Open
pbeaucage opened this issue Mar 27, 2023 · 2 comments

Comments

@pbeaucage
Copy link
Collaborator

The input validation stack between the spreadsheet and the command line do_rsoxs, do_nexafs functions appear to be different: polarizations=90 works in a spreadsheet but from command polarizations requires an Iterable such as a single-element list. It would provide a more consistent user experience to unify the input validation/cleanup code from rsoxs_scans such that the same parameters are accepted for both.

@EliotGann
Copy link
Member

In principle I think this is right, however, do_rsoxs and do_nexafs are not ever suggested to be used in general. spreadsheets have a validation step which these commands do not. There is an expectation that if a user is running the commands directly they should know inputs rather than trusting the running code to clean it up as with spreadsheet input.

@EliotGann
Copy link
Member

If they stick to the output of the columns from the OUTPUT spreadsheets, it should work perfectly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants