Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "detectors" generic to "instruments" #57

Open
nmaytan opened this issue Apr 9, 2024 · 3 comments
Open

Make "detectors" generic to "instruments" #57

nmaytan opened this issue Apr 9, 2024 · 3 comments

Comments

@nmaytan
Copy link
Collaborator

nmaytan commented Apr 9, 2024

In speaking with Bruce, he shared an opinion that assets directories are needed for more than just detectors, i.e. other kinds of instruments that aren't considered to be detectors. This opinion is consistent with the motivation of assets, we just didn't spend a lot of time thinking about the name used in the backend.

The mechanism is sufficient to create whatever arbitrary instrument directories as-is, of course, but it might better to reflect the intended usage throughout the API and database layers.

@nmaytan
Copy link
Collaborator Author

nmaytan commented Apr 10, 2024

I realized this awkwardly conflicts with the fact that beamlines are called "instruments" as well. Perhaps a more specific name like beamline_daq_instrument would be better.

@stuartcampbell
Copy link
Collaborator

If we feel brave we could refactor instruments -> beamlines

@nmaytan
Copy link
Collaborator Author

nmaytan commented May 1, 2024

I'm rather partial to that suggestion, calling them "instruments" is unusual to me. Would this make us inconsistent with PASS?... (and do I care? :p)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants