Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass true MPI size to ScanWindow #46

Closed
leofang opened this issue May 27, 2019 · 0 comments
Closed

Pass true MPI size to ScanWindow #46

leofang opened this issue May 27, 2019 · 0 comments
Milestone
v1.1.0

Comments

@leofang
Copy link
Contributor

leofang commented May 27, 2019

Currently we pass num_processes to ScanWindow:
https://github.com/leofang/ptycho_gui/blob/6e9ea6d5aea1a5f3642fd1acc20a8ba2c2d62718/nsls2ptycho/ptycho_gui.py#L550
However, if the MPI machine file is used, the actual MPI size is counted during initialization:
https://github.com/leofang/ptycho_gui/blob/9e62e62f409b495e83c8a24640f221704990eb58/nsls2ptycho/core/ptycho_recon.py#L99-L125
This workflow needs to be changed/refactored so that the correct size is passed to ScanWindow.

May be relevant: #21
@leofang leofang added this to the v1.1.1 milestone May 27, 2019
@leofang leofang modified the milestones: v1.1.1, v1.1.0 May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@leofang